a little about docker #6
Labels
No labels
accessibility
bug
contribution welcome
duplicate
enhancement
good first issue
help wanted
invalid
question
upstream
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
tom79/Holos-Relay-Server#6
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I just have some questions about docker files in this repo:
export $(cat .env.docker | xargs)instead thatenvironment_filein docker-compose.yml1 - Docker uses a separate
.env.dockerfile. Thedocker-compose.ymlthen adds defaults, validates required vars, and rewrites hosts to container names. env_file would pass values as-is without that.2 - That's only the tunnel service, it shares the relay's source code and dependencies without its own Dockerfile. The relay service itself uses a proper immutable multi-stage build.
i still don't sure why you need to pass node_modules and package.json for tunnel, why not using relay container and changing the entrypoint?
also environment and env_file can be used at the same time so you can do what you want
Thanks for the feedback! I have switched to
env_file+ environment for overrides, and the tunnel now reuses the relay image instead of mounting volumes.